Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt new iOS xml structure #2158

Merged
merged 1 commit into from
Aug 31, 2021
Merged

feat: Adapt new iOS xml structure #2158

merged 1 commit into from
Aug 31, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Aug 30, 2021

Fixes #2144

Test Plan

How do we know the code works?

iOS XML report is changed:

  • Test suite is now empty
  • Previous testsuite name is added as a prefix to the classname
  1. Run iOS tests without option async: true
  2. Check generated XML report

Before:

<?xml version='1.0' encoding='UTF-8' ?>
<testsuites>
  <testsuite name="iphone8-11.4-en_US-portrait#EarlGreyExampleSwiftTests" tests="1" failures="0" errors="0" skipped="0" time="1.969" hostname="localhost">
    <testcase name="testLayout()" classname="EarlGreyExampleSwiftTests" time="1.968">
      <webLink>https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.a3b607c9bb6d0088/matrices/7816289963561003834/executions/bs.4bace0b897feb88b</webLink>
    </testcase>
  </testsuite>
</testsuites>

After

<?xml version='1.0' encoding='UTF-8' ?>
<testsuites>
  <testsuite name="" tests="1" failures="0" errors="0" skipped="0" time="1.958" hostname="localhost">
    <testcase name="testLayout()" classname="iphone8-11.4-en_US-portrait#EarlGreyExampleSwiftTests.EarlGreyExampleSwiftTests" time="1.957">
      <webLink>https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.a3b607c9bb6d0088/matrices/8549684621728392308/executions/bs.1e34a280d8b442cd</webLink>
    </testcase>
  </testsuite>
</testsuites>

@github-actions
Copy link
Contributor

Timestamp: 2021-08-30 18:31:58
Buildscan url for ubuntu-workflow run 1183273064
https://gradle.com/s/bex2qoztnl3fq

@pawelpasterz
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2021

Integration tests succeed for all OSs ✅
Windows Build scan: https://gradle.com/s/kwvdna7s77js4
MacOS Build scan:
Linux Build scan: https://gradle.com/s/mqnmdhduzdfdu
Workflow run https://github.com/Flank/flank/actions/runs/1183589257

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mergify mergify bot merged commit 87fe7e0 into master Aug 31, 2021
@mergify mergify bot deleted the 2144_ios_xml branch August 31, 2021 07:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update parsing for new iOS XML Changes
3 participants