Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement env parsing #2131

Merged
merged 2 commits into from
Aug 13, 2021
Merged

feat: Implement env parsing #2131

merged 2 commits into from
Aug 13, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Aug 12, 2021 •
edited
Loading

Fixes #1882

Test Plan

How do we know the code works?

  1. run ./gradlew flankFullRun
  2. export env variable with test targets, i.e. 
    export TEST_TARGETS="class your.test.Clazz, notAnnotation your.any.Annotation"
  3. update your config with env: 
    test-targets:
  - $TEST_TARGETS
  4. start flank test run and see test targets being applied

Checklist

  • Documented
  • Unit tested

@pawelpasterz pawelpasterz self-assigned this Aug 12, 2021
@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2021 •
edited
Loading

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/d6kzrrg6tvlk4
Linux Build scan: https://gradle.com/s/t74vtyofeefwy
Workflow run https://github.com/Flank/flank/actions/runs/1122873168

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2021 •
edited
Loading

Timestamp: 2021-08-13 11:27:33
Buildscan url for ubuntu-workflow run 1127453686
https://gradle.com/s/yjmjzew5yuyyu

@pawelpasterz pawelpasterz marked this pull request as ready for review August 12, 2021 07:12
@pawelpasterz pawelpasterz enabled auto-merge (squash) August 12, 2021 07:13
@pawelpasterz pawelpasterz force-pushed the 1882-add-test-targets-from-envs branch from fd89cb5 to 8aa43a4 Compare August 12, 2021 07:14
@piotradamczyk5 piotradamczyk5 self-requested a review August 13, 2021 11:18
@pawelpasterz pawelpasterz force-pushed the 1882-add-test-targets-from-envs branch from 677bd43 to 489ba8a Compare August 13, 2021 11:20
@pawelpasterz pawelpasterz merged commit 17004a6 into master Aug 13, 2021
@pawelpasterz pawelpasterz deleted the 1882-add-test-targets-from-envs branch August 13, 2021 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@Sloox Sloox Sloox approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set test-targets for test-run based on env vars
3 participants
@pawelpasterz @Sloox @piotradamczyk5