Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix output of calculateShards() when all tests are filtered out #2129

Merged
merged 1 commit into from
Aug 11, 2021
Merged

fix: Fix output of calculateShards() when all tests are filtered out #2129

merged 1 commit into from
Aug 11, 2021

Conversation

doodla
Copy link
Contributor

@doodla doodla commented Aug 10, 2021

When all tests were filtered out, it would throw an error Invalid shard time.

Test Plan

How do we know the code works?
Create a test apk with one test class with an annotation, and @Ignored.
Filter the tests using that annotation.

Console should print out No tests for ... instead of crashing with Invalid shard time.

Checklist

Couldn't find existing tests for this class.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@doodla
Copy link
Contributor Author

doodla commented Aug 11, 2021

recheck

@doodla
Copy link
Contributor Author

doodla commented Aug 11, 2021

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 11, 2021
@Sloox
Copy link
Contributor

Sloox commented Aug 11, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/zw5mdiw6utb2g
Linux Build scan: https://gradle.com/s/esczo64txjmxk
Workflow run https://github.com/Flank/flank/actions/runs/1119080031

@mergify mergify bot merged commit 517da98 into Flank:master Aug 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2021
@doodla doodla deleted the sv/fix-incorrect-shard-count branch August 11, 2021 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants