Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Envs from additional apks not override default values #2122

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Aug 6, 2021

Fixes #2111

Test Plan

How do we know the code works?

  1. run ./gradlew flankFullRun
  2. create config with
    additional-app-test-apks:
      - test: [...].apk
        environment-variables:
           someVariable: true
    
  3. Your app from additional should see overridden variables

Checklist

  • Unit tested

@pawelpasterz pawelpasterz self-assigned this Aug 6, 2021
@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/wkimh3jyubvnk
Linux Build scan: https://gradle.com/s/i2tjrzos2bedk
Workflow run https://github.com/Flank/flank/actions/runs/1104372435

@github-actions github-actions bot added the Bug label Aug 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Timestamp: 2021-08-09 07:06:22
Buildscan url for ubuntu-workflow run 1111908716
https://gradle.com/s/qn5tfntnrcghu

@pawelpasterz pawelpasterz marked this pull request as ready for review August 6, 2021 10:57
@pawelpasterz pawelpasterz force-pushed the 2111-fix-envs-not-being-overriden branch from 800d9a9 to a0605ad Compare August 9, 2021 06:13
@pawelpasterz pawelpasterz force-pushed the 2111-fix-envs-not-being-overriden branch from f49c523 to 73e3967 Compare August 9, 2021 06:57
@pawelpasterz pawelpasterz enabled auto-merge (squash) August 9, 2021 07:34
@pawelpasterz pawelpasterz merged commit 80d2ea6 into master Aug 9, 2021
@pawelpasterz pawelpasterz deleted the 2111-fix-envs-not-being-overriden branch August 9, 2021 07:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment Variables set using additional-app-test-apks are not overriding
3 participants