Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix dry run #2110

Merged
merged 1 commit into from
Jul 30, 2021
Merged

fix: Fix dry run #2110

merged 1 commit into from
Jul 30, 2021

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1668

Test Plan

How do we know the code works?

  1. run ./gradlew flankFullRun
  2. start any flank run but add --dry flag a the end
  3. dry run should proceed normally, without any errors

@pawelpasterz pawelpasterz enabled auto-merge (squash) July 30, 2021 05:34
@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2021 •
edited
Loading

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/ur5tmasuekowc
Linux Build scan: https://gradle.com/s/opoibabgein4w
Workflow run https://github.com/Flank/flank/actions/runs/1081156775

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2021 •
edited
Loading

Timestamp: 2021-07-30 08:26:07
Buildscan url for ubuntu-workflow run 1081536068
https://gradle.com/s/4e64rev3vfdvg

@pawelpasterz pawelpasterz merged commit 2784a32 into master Jul 30, 2021
@pawelpasterz pawelpasterz deleted the 1668-fix-dry-run branch July 30, 2021 10:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@Sloox Sloox Sloox approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
Bug P2 Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--dry option is not working
3 participants
@pawelpasterz @Sloox @piotradamczyk5