Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Parameterized Tests - multiple #2076

Merged
merged 2 commits into from
Jul 12, 2021
Merged

feat: Parameterized Tests - multiple #2076

merged 2 commits into from
Jul 12, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Jul 9, 2021 •
edited
Loading

Fixes #2024

Test Plan

How do we know the code works?
Parameterized tests are sharded into separate shards and run as expected.
A true smart shard that can take into account the amount of shards is most likely a fruitless pursuit at this point.

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@Sloox Sloox added Tiger 🐯 New Option Used to track PR with new configuration option (useful when updating fladle) labels Jul 9, 2021
@Sloox Sloox self-assigned this Jul 9, 2021
@Sloox Sloox marked this pull request as draft July 9, 2021 09:49
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021 •
edited
Loading

Timestamp: 2021-07-12 11:25:11
Buildscan url for ubuntu-workflow run 1022602471
https://gradle.com/s/vdc7bm3hkdgla

@Sloox Sloox marked this pull request as ready for review July 9, 2021 09:58
@Sloox Sloox removed the Research label Jul 9, 2021
@Sloox
Copy link
Contributor Author

Sloox commented Jul 9, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021 •
edited
Loading

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/dwspvmif57g46
Linux Build scan: https://gradle.com/s/5a7fk3xmsnjn2
Workflow run https://github.com/Flank/flank/actions/runs/1014789191

@Sloox Sloox enabled auto-merge (squash) July 9, 2021 11:18
@bootstraponline bootstraponline force-pushed the #2024-parameterize-tests-multiple branch 2 times, most recently from 3ebc0de to 05b3e3d Compare July 12, 2021 07:57
@bootstraponline bootstraponline force-pushed the #2024-parameterize-tests-multiple branch from 05b3e3d to 51a539b Compare July 12, 2021 11:02
@bootstraponline bootstraponline force-pushed the #2024-parameterize-tests-multiple branch from 51a539b to 0b808fc Compare July 12, 2021 11:17
@Sloox Sloox merged commit 94be354 into master Jul 12, 2021
@Sloox Sloox deleted the #2024-parameterize-tests-multiple branch July 12, 2021 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@jan-goral jan-goral jan-goral approved these changes

@zuziaka zuziaka Awaiting requested review from zuziaka

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

Assignees

@Sloox Sloox

Labels
Feature New Option Used to track PR with new configuration option (useful when updating fladle) P1 Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameterized Tests: Add new options #2
3 participants
@Sloox @jan-goral @adamfilipow92