Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not upload/read files when path starts with gs:// #2075

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Jul 9, 2021

Fixes #1971

When user provides gs:// path in other-files we should not upload it again.

Files.readAllBytes(Paths.get(file))

will never succeed when the path starts with gs://

Test Plan

How do we know the code works?

  1. flank test bucket
  2. run ./gradlew flankFullRun
  3. prepare config with:
    other-files:
        /sdcard/[some file name]: gs://[path to file uploaded to the bucket, you can reuse existing one]
    
  4. run tests
  5. go to result bucket and check if there is a file from config under /artifacts/sdcard/ path

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Timestamp: 2021-07-14 12:23:20
Buildscan url for ubuntu-workflow run 1030192163
https://gradle.com/s/466x2yln5wzzm

Copy link
Contributor

@piotradamczyk5 piotradamczyk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Sloox
Copy link
Contributor

Sloox commented Jul 14, 2021

@flank-it

@Sloox Sloox marked this pull request as ready for review July 14, 2021 12:16
@github-actions
Copy link
Contributor

Integration tests were triggered at 2021-07-14 12:17:19, you can track progress here

@mergify mergify bot merged commit f44162e into master Jul 14, 2021
@mergify mergify bot deleted the 1971-fix-upload-other-files branch July 14, 2021 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't upload file to device with other-files feature with gs:// link
4 participants