Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Flank Wrapper #2064

Merged
merged 14 commits into from
Jul 6, 2021
Merged

feat: Added Flank Wrapper #2064

merged 14 commits into from
Jul 6, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Jul 2, 2021

Fixes #2041

This is the solution to have evergreen Flank. The wrapper will always use the latest version of Flank

Test Plan

How do we know the code works?

  1. Build Flank wrapper with ./gradlew flank_wrapper:shadowJar
  2. Run it with flankw/flankw.bat or java -jar flank_wrapper.jar and provide flank options as usual
  3. Please notice that the latest version should be downloaded just once.

Checklist

  • Documented
  • Unit tested
  • Flank wrapper created
  • Flank wrapper release workflow prepared
  • SHA-256 sum added to Flank

@mergify
Copy link

mergify bot commented Jul 2, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Timestamp: 2021-07-06 12:55:28
Buildscan url for ubuntu-workflow run 1004441355
https://gradle.com/s/fsnjce6zholwm

@bootstraponline
Copy link
Contributor

This looks great! What do you think about using mixpanel to track # of downloads with the Flank wrapper? And use sentry to check to make sure any crashes are reported? These can be done in a follow up PR to keep this one small.

@piotradamczyk5
Copy link
Contributor Author

This looks great! What do you think about using mixpanel to track # of downloads with the Flank wrapper? And use sentry to check to make sure any crashes are reported? These can be done in a follow up PR to keep this one small.

I will create a follow up tickets for it

@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) July 6, 2021 12:49
@piotradamczyk5 piotradamczyk5 merged commit 1474048 into master Jul 6, 2021
@piotradamczyk5 piotradamczyk5 deleted the 2041_flank-wrapper branch July 6, 2021 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Flank wrapper
5 participants