feat: Merge test method duration for parameterized classes #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Timestamp: 2021-07-09 11:26:22 |
Sloox
previously requested changes
Jul 2, 2021
3 tasks
jan-goral
force-pushed
the
2052_Parameterized_tests_durations_support
branch
from
8065ea0 to
1ebb01b
Compare
jan-goral
requested review from
adamfilipow92,
zuziaka,
pawelpasterz and
piotradamczyk5
jan-goral
dismissed
Sloox’s stale review
Because of comment "@jan-gogo ignore that. This is for corellium"
bootstraponline
force-pushed
the
2052_Parameterized_tests_durations_support
branch
from
916937d to
1c0863f
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2021
Fixes #2051 Requires #2055 Enchanted by #2062 ## Changes * Add test targets argument for filtering test cases. * Add filtering option to Apk.ParseTestCases. * Log AndroidTestPlan.Config on ExecuteTests start. * Refactor `:tool:apk` module ## Test Plan > How do we know the code works? build flank ```shell . .env flankScripts assemble flank -d ``` and run ```shell flank corellium test android run -c="./test_configs/flank-corellium.yml" ``` using configuration ```yml auth: "test_configs/corellium_auth.yml" apks: - path: "test_artifacts/master/apk/app-debug.apk" tests: - path: "test_artifacts/master/apk/app-multiple-flaky-debug-androidTest.apk" test-targets: - "package com.example.test_app.parametrized" - "notClass com.example.test_app.parametrized.EspressoParametrizedClassTestParameterized" - "package com.example.test_app.foo" - "class com.example.test_app.InstrumentedTest#test0" max-test-shards: 3 ``` As a results Flank should execute only test cases restricted by test targets. ## Checklist - [x] Documented - [x] Unit tested - [x] Integrated with a filtering tool
bootstraponline
force-pushed
the
2052_Parameterized_tests_durations_support
branch
2 times, most recently
from
f6d8fd2 to
b8e186e
Compare
Sloox
approved these changes
Jul 8, 2021
| JUnit.TestResult( | ||
| suiteName = suite.name, | ||
| testName = case.name, | ||
| className = case.classname, | ||
| startAt = 0, | ||
| endsAt = (case.time * 1000).toLong(), | ||
| startAt = startAt.also { startAt = endAt }, |
There was a problem hiding this comment.
wont this simply result in
endAt = endAt
&
startAt = endAt?
There was a problem hiding this comment.
I don't understand your suggestion, but it's reminded me that I had forgotten to add a proper test (Thx for that 👍). So, I added a small update. If you see a shorter solution, feel free to check out the branch and test it using StructuralKtTest.mapToTestResultsTest
There was a problem hiding this comment.
Right, this part .also { startAt = endAt } was redundant.
bootstraponline
force-pushed
the
2052_Parameterized_tests_durations_support
branch
2 times, most recently
from
bcfc0b9 to
4d9b334
Compare
jan-goral
commented
Jul 9, 2021
bootstraponline
force-pushed
the
2052_Parameterized_tests_durations_support
branch
from
5af09f6 to
2c7bf3e
Compare
zuziakaxel-shape
approved these changes
Jul 9, 2021
zuziaka
approved these changes
Jul 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2052
Changes
:tool:junitfunction for merging test methods into test-class with accumulated duration.Test Plan
Build flank:
. .env flankScripts assemble flank -dRun the following command twice:
The second run should calculate durations for parameterized classes.
Check generated
android-shards.jsoneach parameterized class should have a duration different than the default (120).Checklist