refactor: Make the domain a source of defaults #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Timestamp: 2021-07-05 12:12:47 |
Sloox
approved these changes
Jul 1, 2021
bootstraponline
force-pushed
the
Defaults_from_domain
branch
3 times, most recently
from
272b677 to
a2396d1
Compare
jan-goral
requested review from
adamfilipow92,
zuziaka,
pawelpasterz and
piotradamczyk5
bootstraponline
force-pushed
the
Defaults_from_domain
branch
4 times, most recently
from
dd3d5ba to
34bdcb6
Compare
bootstraponline
force-pushed
the
Defaults_from_domain
branch
from
34bdcb6 to
c20ee71
Compare
adamfilipow92
approved these changes
Jul 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing a bad design where the CLI layer is defining default arguments.
The change is the CLI now is depending on defaults from the domain module.