-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Data field should not be serialized #2039
Conversation
Title does not follow the guidelines of Conventional Commits.
|
@adamfilipow92 @piotradamczyk5 Please take a look |
@flank-it |
Integration tests succeed for all OSes ✅ |
Timestamp: 2021-06-21 08:17:50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #2018
commonArgs
->data
field is redundant. It is represented by yml file read as a raw string. Flank copiesyml
file and all values (from config) are present in report json in dedicated fields. Therefor I think we can make it transient (not serializable)Test Plan
outputReport.json
data
field incommonArgs