Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Data field should not be serialized #2039

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Jun 21, 2021

Fixes #2018

commonArgs -> data field is redundant. It is represented by yml file read as a raw string. Flank copies yml file and all values (from config) are present in report json in dedicated fields. Therefor I think we can make it transient (not serializable)

Test Plan

How do we know the code works?

  1. run any flank test
  2. open outputReport.json
  3. There should be no data field in commonArgs

@mergify
Copy link

mergify bot commented Jun 21, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@pawelpasterz
Copy link
Contributor Author

@adamfilipow92 @piotradamczyk5 Please take a look

@pawelpasterz
Copy link
Contributor Author

@flank-it

@pawelpasterz pawelpasterz changed the title refactor:Data field should not be serialized refactor: Data field should not be serialized Jun 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2021

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/nxjorizsi2yro
Linux Build scan: https://gradle.com/s/ewhuqcgoyogsa
Workflow run https://github.com/Flank/flank/actions/runs/955712248

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2021

Timestamp: 2021-06-21 08:17:50
Buildscan url for ubuntu-workflow run 956330384
https://gradle.com/s/f7wkl7ctfu466

@pawelpasterz pawelpasterz enabled auto-merge (squash) June 21, 2021 05:03
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pawelpasterz pawelpasterz merged commit ced7de4 into master Jun 21, 2021
@pawelpasterz pawelpasterz deleted the 2018-remove-data-from-report-json branch June 21, 2021 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ugly format of data in outputReport.json
3 participants