Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add structural logging #2032

Merged
merged 9 commits into from
Jun 24, 2021
Merged

feat: Add structural logging #2032

merged 9 commits into from
Jun 24, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Jun 16, 2021 •
edited
Loading

Fixes #1999

  • Adds structural log types
  • Replaces print lines with structural logging in modules:
    • domain
    • adapter
    • client
  • Mapps structural logs to console output in CLI module

Test Plan

How do we know the code works?

Flank-Corellium is producing console logs as previously.

Checklist

  • Unit tested

@jan-goral jan-goral self-assigned this Jun 16, 2021
@jan-goral jan-goral force-pushed the 1999_Implement_stuctural_logging_for_RunTestCorelliumAndroid branch from c47ed84 to 551a470 Compare June 16, 2021 10:47
This was referenced Jun 17, 2021
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jun 18, 2021
@jan-goral
feat: Remove print lines from Corellium client (#2034)
46a701f 
Related to #1999 

* Remove unneeded print lines from `:corellium:client`
* Optimize internal implementation of `:corellium:client`

This PR is implementing fixes required by #2032.
Merging this will simplify #2032.
mergify bot pushed a commit that referenced this pull request Jun 19, 2021
@jan-goral
feat: Add tools for structural logging (#2033)
33e946f 
Related to #1999 

This PR is adding simple tools for structural logging and formatting, required by PR #2032. 
Merging this will simplify #2032.

## Test Plan
> How do we know the code works?

Unit test passes.

## Checklist

- [x] Documented
- [x] Unit tested
@jan-goral jan-goral force-pushed the 1999_Implement_stuctural_logging_for_RunTestCorelliumAndroid branch 3 times, most recently from 7cdd795 to 42adf59 Compare June 21, 2021 08:30
@jan-goral jan-goral marked this pull request as ready for review June 21, 2021 09:05
@jan-goral jan-goral force-pushed the 1999_Implement_stuctural_logging_for_RunTestCorelliumAndroid branch from eb451ca to 39c35a9 Compare June 24, 2021 09:03
@github-actions
Copy link
Contributor

Timestamp: 2021-06-24 09:11:27
Buildscan url for ubuntu-workflow run 967358050
https://gradle.com/s/arxnjv4lvuuew

@mergify mergify bot merged commit 2545334 into master Jun 24, 2021
@mergify mergify bot deleted the 1999_Implement_stuctural_logging_for_RunTestCorelliumAndroid branch June 24, 2021 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

Assignees

@jan-goral jan-goral

Labels
Corellium Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement stuctural logging for RunTestCorelliumAndroid
3 participants
@jan-goral @Sloox @pawelpasterz