feat: Set Google api issues level as DEBUG #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
Timestamp: 2021-06-08 12:34:40 |
pawelpasterz
reviewed
Jun 8, 2021
| @@ -54,7 +55,7 @@ internal fun withGlobalExceptionHandling(block: () -> Int, exitProcessFunction: | |||
| } | |||
|
|
|||
| is InfrastructureError -> { | |||
There was a problem hiding this comment.
Do we want to change log level for FTLError as well?
There was a problem hiding this comment.
I am not sure, does FTLError occurs only on Google Api issues?
There was a problem hiding this comment.
According to error description, it's thrown when an internal error occurs.
So I guess you are right...
There was a problem hiding this comment.
we could leave it for now and see later how it is working
bootstraponline
force-pushed
the
1958-change-sentry-events
branch
from
416d886 to
e568d3e
Compare
pawelpasterz
approved these changes
Jun 9, 2021
Sloox
approved these changes
Jun 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1958
Test Plan
When a Google infrastructure issue occurs(FlankGoogleApiError, InfrastructureError) it is logged with log level DEBUG.
You could throw this exception on your own
InfrastructureError("test").report(SentryLevel.DEBUG). This feature will be used for creating Sentry notification about critical errors to the newly created channel#sentry-errors