Fix: bucket not found but can't be created

[CristianGM]

Flank was showing:

Warning: Failed to make bucket for ...
Cause: Sorry, that name is not available. Please try a different one.

It didn't find the bucket but it was there, the reason is the list of buckets was never set.

It's been broken since: https://github.com/Flank/flank/pull/531/files#diff-81920894b2478868a06b5f2210f003afaf3ca682d7cb61afe1c8dec2cecdb191R127

Test Plan

Tested manually but looking if on how to write an automated test

Checklist

• Documented
• Unit tested
• Integration tests updated

I have read the CLA Document and I hereby sign the CLA

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[Sloox]

Hi @CristianGM

Nice to see this is your first contribution to Flank. 🥳
Could you please type, "I have read the CLA Document and I hereby sign the CLA" in a separate ticket. The bot appears to not have recognized it. Also you may need to type: "recheck" in a separate post (Also separate from the acceptance post.)

Is there a corresponding bug ticket related to the issue you are experiencing? It would be great to understand exactly what the issue is. It would greatly help us.

Thanks,
The Flank Team.

[CristianGM]

I have read the CLA Document and I hereby sign the CLA

[CristianGM]

I've left this PR without tests because I don't see any simple way of writing one.

ArgsHelperTest has a test for the method I modified, createGcsBucket, but i would need to spy on storage to see create is not called...of maybe assert the log contains no warning..

Any ideas?
Do you feel it's fine without adding a test?

[bootstraponline]

This is a fix for the bug discussed here: https://firebase-community.slack.com/archives/C72V6UW8M/p1622460325013400

Flank always prints a warning Warning: Failed to make bucket for PROJECT_ID because storageList is not updated after calling bucket.list.

I agree a test would be great, not sure how to test this though.

[pawelpasterz]

Oh...nice one, thanks for fixing it! Let's verify with integration tests and we're good to go

[pawelpasterz]

@flank-it

[github-actions]

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status success - Build scan: https://gradle.com/s/rlc4i7mudsnj4
Linux status success - Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/905114364

[pawelpasterz]

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status success - Build scan: https://gradle.com/s/rlc4i7mudsnj4
Linux status success - Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/905114364

Windows failed due to unrelated issue

[Sloox]

Failing IT tests will be investigated in another ticket.
Other than that approved.