Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add user guide for Corellium MVP #1977

Merged
merged 5 commits into from
May 31, 2021
Merged

docs: Add user guide for Corellium MVP #1977

merged 5 commits into from
May 31, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented May 28, 2021 •
edited
Loading

@jan-goral jan-goral added Documentation Pull request which touches documentation Corellium labels May 28, 2021
@jan-goral jan-goral self-assigned this May 28, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2021 •
edited
Loading

Timestamp: 2021-05-31 12:12:01
Buildscan url for ubuntu-workflow run 892834252
https://gradle.com/s/pk6lypfvhhk2a

piotradamczyk5
piotradamczyk5 previously requested changes May 28, 2021
View reviewed changes
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 left a comment •
edited by jan-goral
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue described here #1979

@adamfilipow92

This comment has been minimized.

Sign in to view
Sloox
Sloox reviewed May 31, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes.

docs/flank_corellium.md Outdated Show resolved Hide resolved
docs/flank_corellium.md Outdated Show resolved Hide resolved
docs/flank_corellium.md Outdated Show resolved Hide resolved
docs/flank_corellium.md Outdated Show resolved Hide resolved
docs/flank_corellium.md Outdated Show resolved Hide resolved
docs/flank_corellium.md Outdated Show resolved Hide resolved
docs/flank_corellium.md Outdated Show resolved Hide resolved
jan-goral
jan-goral commented May 31, 2021
View reviewed changes
docs/flank_corellium.md Outdated Show resolved Hide resolved
@jan-goral
Copy link
Contributor Author

Fixes.

Thanks!!! 👍

@jan-goral jan-goral marked this pull request as ready for review May 31, 2021 10:00
@jan-goral jan-goral dismissed piotradamczyk5’s stale review May 31, 2021 10:02

Related to another already merged PR, not this one directly.

@bootstraponline bootstraponline force-pushed the 1976_Add_user_guide_for_Corellium_MVP branch from 4d7e63f to 2abcfea Compare May 31, 2021 11:52
@bootstraponline bootstraponline force-pushed the 1976_Add_user_guide_for_Corellium_MVP branch from 2abcfea to d35fe70 Compare May 31, 2021 12:05
@mergify mergify bot merged commit bcc6805 into master May 31, 2021
@mergify mergify bot deleted the 1976_Add_user_guide_for_Corellium_MVP branch May 31, 2021 14:39
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@Sloox Sloox Sloox approved these changes

@zuziaka zuziaka Awaiting requested review from zuziaka

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

Assignees

@jan-goral jan-goral

Labels
Corellium Documentation Pull request which touches documentation Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add user guide for Corellium MVP
4 participants
@jan-goral @adamfilipow92 @Sloox @piotradamczyk5