fix: Filter devices without supported versions #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Timestamp: 2021-05-25 11:38:59 |
pawelpasterz
force-pushed
the
1892-fix-firebase-device-list
branch
from
21cc6ff to
5c60bf9
Compare
Sloox
approved these changes
May 25, 2021
| fun getModels(projectId: String): List<AndroidModel> = deviceCatalog(projectId).models.orEmpty() | ||
|
|
||
| fun supportedVersionsAsTable(projectId: String) = fetchAndroidOsVersion(projectId).toCliTable() | ||
|
|
||
| fun describeSoftwareVersion(projectId: String, versionId: String) = fetchAndroidOsVersion(projectId).getDescription(versionId) | ||
| fun describeSoftwareVersion(projectId: String, versionId: String) = | ||
| fetchAndroidOsVersion(projectId).getDescription(versionId) |
There was a problem hiding this comment.
I would prefer:
fun describeSoftwareVersion(
projectId: String,
versionId: String
) = fetchAndroidOsVersion(projectId).getDescription(versionId)
but this is just a suggestion, please check other places
There was a problem hiding this comment.
Ah sorry, it was merged before I implemented changes. Will do it within another PR
piotradamczyk5
approved these changes
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1892
Test Plan
./gradlew flankFullRunflank firebase test ios models listand compare withgcloud firebase test ios models list-- there should be no differentflank firebase test android models listand compare withgcloud firebase test android models list-- there should be no differentChecklist