Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add implementation section to architecture doc #1961

Merged
merged 7 commits into from
May 26, 2021
Merged

docs: Add implementation section to architecture doc #1961

merged 7 commits into from
May 26, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented May 24, 2021 •
edited
Loading

Fixes #1960

This PR is adding a section about how to meet architecture requirements in implementation.

added section

Checklist

  • Update diagram links before merge

@jan-goral jan-goral self-assigned this May 24, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jan-goral jan-goral force-pushed the 1960_Add_implementation_section_to_architecture_doc branch from ff648c1 to e177e94 Compare May 24, 2021 11:08
@jan-goral jan-goral force-pushed the 1960_Add_implementation_section_to_architecture_doc branch from 0a01178 to fd0bade Compare May 24, 2021 11:13
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2021 •
edited
Loading

Timestamp: 2021-05-26 11:31:20
Buildscan url for ubuntu-workflow run 878332852
https://gradle.com/s/nuxynzt6ltd44

@jan-goral jan-goral marked this pull request as ready for review May 25, 2021 10:37
@jan-goral jan-goral changed the title Add architecture abstraction doc docs: Add architecture abstraction May 25, 2021
@jan-goral jan-goral added the Documentation Pull request which touches documentation label May 25, 2021
Sloox
Sloox suggested changes May 26, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
@jan-goral
Copy link
Contributor Author

👍

@Sloox Thx for the corrections ❤️. All applied

@jan-goral jan-goral requested a review from Sloox May 26, 2021 11:20
@jan-goral jan-goral changed the title docs: Add architecture abstraction docs: Add implementation section to architecture doc May 26, 2021
@mergify mergify bot merged commit ec4202d into master May 26, 2021
@mergify mergify bot deleted the 1960_Add_implementation_section_to_architecture_doc branch May 26, 2021 11:37
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@Sloox Sloox Sloox approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziaka zuziaka Awaiting requested review from zuziaka

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

Assignees

@jan-goral jan-goral

Labels
Documentation Pull request which touches documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add implementation section to architecture doc
3 participants
@jan-goral @Sloox @pawelpasterz