fix: annotation filtering for parameterized classes #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
asadsalman
changed the title
test_runner/src/main/kotlin/ftl/run/platform/android/CreateAndroidTestContext.kt
Outdated
Show resolved
Hide resolved
bootstraponline
force-pushed
the
asalman/parameterized-filter-fix
branch
from
12e1259 to
1de951d
Compare
|
@flank-it |
Sloox
requested review from
pawelpasterz,
adamfilipow92,
jan-goral,
Sloox,
zuziaka,
bootstraponline and
piotradamczyk5
|
Integration tests were triggered at 2021-05-24 09:04:53, you can track progress here |
bootstraponline
force-pushed
the
asalman/parameterized-filter-fix
branch
from
1de951d to
7839949
Compare
IT passed, but there was a problem with API limit |
bootstraponline
force-pushed
the
asalman/parameterized-filter-fix
branch
from
7839949 to
00c8a77
Compare
pawelpasterz
approved these changes
May 25, 2021
piotradamczyk5
approved these changes
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
annotationandnotAnnotationfiltering for parameterized classes.Test Plan
Unit tests which test both annotation filters are added.
.
Checklist