feat: Integrate flank.jar with corellium CLI #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Timestamp: 2021-05-18 15:30:38 |
jan-goral
force-pushed
the
1944_Integrate_flank-corellium_cli
branch
from
d079394 to
17f9c7a
Compare
bootstraponline
force-pushed
the
1944_Integrate_flank-corellium_cli
branch
from
17f9c7a to
fd783c9
Compare
jan-goral
requested review from
Sloox,
adamfilipow92,
zuziaka,
pawelpasterz and
piotradamczyk5
jan-goral
changed the title
Sloox
approved these changes
May 18, 2021
| // TODO steps will be added in next PR | ||
| ) | ||
| State() execute flowOf { | ||
| println("Not integrated yet, check following PR:") |
There was a problem hiding this comment.
nit: Let's use logLn here
There was a problem hiding this comment.
It's not accessible in this module.
bootstraponline
force-pushed
the
1944_Integrate_flank-corellium_cli
branch
from
fd783c9 to
25049a9
Compare
pawelpasterz
approved these changes
May 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1944
Test Plan
$ flank corellium test android runis executingflank.corellium.cli.RunTestCorelliumAndroidCommandChecklist