Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Public API of corellium domain layer #1935

Merged
merged 1 commit into from
May 14, 2021
Merged

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented May 14, 2021

Related to #1802

The public API of the domain layer is required for CLI integration.
The rest of the domain layer implementation will be added in another PR.

Checklist

  • Documented

@jan-goral jan-goral self-assigned this May 14, 2021
@github-actions
Copy link
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mergify
Copy link

mergify bot commented May 14, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@jan-goral jan-goral changed the title Add public API of domain layer without business logic. feat: Public API of corellium domain layer May 14, 2021
@github-actions
Copy link
Contributor

Timestamp: 2021-05-14 10:05:37
Buildscan url for ubuntu-workflow run 841801391
https://gradle.com/s/c2jvydv3rhku2

@mergify mergify bot merged commit 21bfc9e into master May 14, 2021
@mergify mergify bot deleted the 1802_Corellium_domain-api branch May 14, 2021 11:01
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants