Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Structural output list provided software #1919

Merged
merged 1 commit into from
May 12, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1865

Test Plan

How do we know the code works?

Code is refactored according to #1865
firebase test provided-software list works like previously

Checklist

  • Refactored

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2021

Timestamp: 2021-05-12 14:31:56
Buildscan url for ubuntu-workflow run 835794090
https://gradle.com/s/t3s6ebpwcqfci

@bootstraponline bootstraponline force-pushed the 1865_list_provided_software branch from c2cd948 to 50b1a91 Compare May 11, 2021 18:53
@mergify
Copy link

mergify bot commented May 11, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@piotradamczyk5 piotradamczyk5 marked this pull request as draft May 12, 2021 05:22
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review May 12, 2021 06:55
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) May 12, 2021 06:56
@bootstraponline bootstraponline force-pushed the 1865_list_provided_software branch from 50b1a91 to a871085 Compare May 12, 2021 13:04
@bootstraponline bootstraponline force-pushed the 1865_list_provided_software branch from a871085 to a0fdf75 Compare May 12, 2021 14:26
@piotradamczyk5 piotradamczyk5 merged commit 58ed388 into master May 12, 2021
@piotradamczyk5 piotradamczyk5 deleted the 1865_list_provided_software branch May 12, 2021 15:51
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structural output - ListProvidedSoftware
3 participants