refactor: Remove client classes for JUnit refactor #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Timestamp: 2021-05-11 17:36:32 |
Sloox
reviewed
May 11, 2021
| import ftl.client.google.downloadAsJunitXml | ||
|
|
||
| object DownloadAsJunitXML : | ||
| FileReference.DownloadAsXML, | ||
| (FileReference) -> JUnitTest.Result by { fileReference -> | ||
| downloadAsJunitXml(fileReference).toApiModel() |
There was a problem hiding this comment.
@piotradamczyk5 I am a little confused as the removal of .toApiModel. Whats this change for? Or why?
There was a problem hiding this comment.
@jan-gogo suggest that we should use api data classes also in client, because they are small
piotradamczyk5
force-pushed
the
fixes_for_junit_refactor
branch
from
0ff7ae8 to
884315a
Compare
bootstraponline
force-pushed
the
fixes_for_junit_refactor
branch
from
5c1069a to
88a2647
Compare
adamfilipow92
approved these changes
May 11, 2021
bootstraponline
force-pushed
the
fixes_for_junit_refactor
branch
2 times, most recently
from
8da299c to
070e5e7
Compare
bootstraponline
force-pushed
the
fixes_for_junit_refactor
branch
from
070e5e7 to
ee0a9d9
Compare
pawelpasterz
approved these changes
May 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
This PR contains additional fixes for JUnit data layer refactor after conversation with @jan-gogo on Slack
Checklist