Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Structural output for list android models #1907

Merged
merged 1 commit into from
May 11, 2021

Conversation

adamfilipow92
Copy link
Contributor

Fixes #1856

Test Plan

How do we know the code works?

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2021

Timestamp: 2021-05-11 18:40:42
Buildscan url for ubuntu-workflow run 832750150
https://gradle.com/s/grkycezaw3clc

@bootstraponline bootstraponline force-pushed the 1856-structural-output-list-android-models branch from 118dfcf to 08291e0 Compare May 10, 2021 12:41
@adamfilipow92 adamfilipow92 changed the title refactor: Structural output list android models refactor: Structural output for list android models May 10, 2021
@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2021

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/yuuhlhbapjjm4
Linux Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/828106106

@bootstraponline bootstraponline force-pushed the 1856-structural-output-list-android-models branch from 08291e0 to 7b691ac Compare May 10, 2021 13:39
@bootstraponline bootstraponline force-pushed the 1856-structural-output-list-android-models branch 6 times, most recently from 3a60d11 to 61f7133 Compare May 11, 2021 17:47
@mergify
Copy link

mergify bot commented May 11, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@pawelpasterz
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link

mergify bot commented May 11, 2021

Command refresh: success

Pull request refreshed

@bootstraponline bootstraponline force-pushed the 1856-structural-output-list-android-models branch from 61f7133 to a34b79b Compare May 11, 2021 18:35
@mergify mergify bot merged commit 3636924 into master May 11, 2021
@mergify mergify bot deleted the 1856-structural-output-list-android-models branch May 11, 2021 18:46
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structural output - ListAndroidModels
3 participants