Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Data scratch - test matrix #1901

Merged
merged 16 commits into from
May 11, 2021
Merged

refactor: Data scratch - test matrix #1901

merged 16 commits into from
May 11, 2021

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented May 7, 2021 •
edited
Loading

Fixes #1756

Test Plan

How do we know the code works?

  • All tests pass
  • Flank works as before

Checklist

  • Unit tests updated

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/w6k4zkwjmo7ac
Linux status - Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/820344660

@piotradamczyk5
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/wcljmxsgjyk4m
Linux Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/820696837

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2021 •
edited
Loading

Timestamp: 2021-05-10 13:46:34
Buildscan url for ubuntu-workflow run 828240536
https://gradle.com/s/sshc2uqj2mfee

@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/tz3nsi4mwdxtg
Linux Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/823163681

@adamfilipow92 adamfilipow92 marked this pull request as ready for review May 8, 2021 14:01
@piotradamczyk5 piotradamczyk5 force-pushed the 1756-reactor-test-matrix branch from 75c5ecc to 799f0d5 Compare May 10, 2021 11:01
Sloox
Sloox reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

test_runner/src/main/kotlin/ftl/client/google/FetchTestMatrices.kt Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/client/google/FetchTestMatrices.kt Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/reports/util/ReportManager.kt Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/reports/util/ReportManager.kt Outdated Show resolved Hide resolved
test_runner/src/test/kotlin/ftl/json/SavedMatrixTest.kt Show resolved Hide resolved
test_runner/src/test/kotlin/ftl/json/MatrixMapTest.kt Outdated Show resolved Hide resolved
@bootstraponline bootstraponline force-pushed the 1756-reactor-test-matrix branch from 26b198d to bb1ed33 Compare May 10, 2021 13:41
@Sloox Sloox self-requested a review May 11, 2021 07:40
Sloox
Sloox approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 66e796c into master May 11, 2021
@mergify mergify bot deleted the 1756-reactor-test-matrix branch May 11, 2021 07:43
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@Sloox Sloox Sloox approved these changes

Assignees

@adamfilipow92 adamfilipow92

@piotradamczyk5 piotradamczyk5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data scratch - test matrix
4 participants
@adamfilipow92 @piotradamczyk5 @Sloox @pawelpasterz