Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Logging refactor - android/ios test environment #1896

Merged
merged 6 commits into from
May 7, 2021
Merged

refactor: Logging refactor - android/ios test environment #1896

merged 6 commits into from
May 7, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented May 5, 2021 •
edited
Loading

Fixes #1847 #1851

Test Plan

How do we know the code works?

  1. run ./gradlew flankFullRun
  2. run flank android test-environment
  3. run flank ios test-environment
  4. 🎉

@pawelpasterz pawelpasterz self-assigned this May 5, 2021
@pawelpasterz pawelpasterz changed the title reafactor: Logging refactor - android test environment refactor: Logging refactor - android test environment May 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021 •
edited
Loading

Timestamp: 2021-05-06 16:04:09
Buildscan url for ubuntu-workflow run 817443545
https://gradle.com/s/fkg3c5am5hlgu

@pawelpasterz pawelpasterz force-pushed the 1847-refactor-logging-android-test-environment branch from 21b92ea to 8728ab8 Compare May 5, 2021 10:43
@pawelpasterz pawelpasterz marked this pull request as ready for review May 5, 2021 10:43
@pawelpasterz pawelpasterz enabled auto-merge (squash) May 5, 2021 10:43
@pawelpasterz pawelpasterz force-pushed the 1847-refactor-logging-android-test-environment branch 2 times, most recently from b8a08cb to cda1260 Compare May 6, 2021 12:17
@pawelpasterz pawelpasterz changed the title refactor: Logging refactor - android test environment refactor: Logging refactor - android/ios test environment May 6, 2021
@pawelpasterz pawelpasterz force-pushed the 1847-refactor-logging-android-test-environment branch from 0c2acf1 to c75f39b Compare May 6, 2021 15:26
@pawelpasterz pawelpasterz force-pushed the 1847-refactor-logging-android-test-environment branch from c75f39b to 9bc0c62 Compare May 6, 2021 15:58
Sloox
Sloox approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawelpasterz pawelpasterz merged commit 1deaca0 into master May 7, 2021
@pawelpasterz pawelpasterz deleted the 1847-refactor-logging-android-test-environment branch May 7, 2021 13:33
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@Sloox Sloox Sloox approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@pawelpasterz pawelpasterz

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structural output - DescribeAndroidTestEnvironment
3 participants
@pawelpasterz @Sloox @piotradamczyk5