Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Structural output iOS models describe #1895

Merged
merged 1 commit into from
May 6, 2021
Merged

refactor: Structural output iOS models describe #1895

merged 1 commit into from
May 6, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1850

Test Plan

How do we know the code works?

Checklist

  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@piotradamczyk5 piotradamczyk5 changed the title refactor: Refactor data scratch-device model refactor: Structural output iOS models describe May 4, 2021
@piotradamczyk5 piotradamczyk5 force-pushed the 1850_structural_output_ios_models_describe branch 2 times, most recently from 599384d to 06e911e Compare May 4, 2021 14:20
@piotradamczyk5 piotradamczyk5 changed the title refactor: Structural output iOS models describe refactor: Structural output iOS models describe May 4, 2021
@piotradamczyk5 piotradamczyk5 force-pushed the 1850_structural_output_ios_models_describe branch 2 times, most recently from 6f531bb to 0c8ac6a Compare May 4, 2021 16:01
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021 •
edited
Loading

Timestamp: 2021-05-05 10:46:39
Buildscan url for ubuntu-workflow run 813117568
https://gradle.com/s/khvagl2dgw4ti

@Flank Flank deleted a comment from mergify bot May 4, 2021
@Flank Flank deleted a comment from mergify bot May 4, 2021
@Flank Flank deleted a comment from mergify bot May 4, 2021
@bootstraponline bootstraponline force-pushed the 1850_structural_output_ios_models_describe branch from 0c8ac6a to d375469 Compare May 5, 2021 10:40
Sloox
Sloox approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify bot merged commit 307b583 into master May 6, 2021
@mergify mergify bot deleted the 1850_structural_output_ios_models_describe branch May 6, 2021 06:56
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structural output - DescribeIosModels
3 participants
@piotradamczyk5 @Sloox @pawelpasterz