Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Structural output Android models describe #1887

Merged
merged 1 commit into from
May 4, 2021
Merged

refactor: Structural output Android models describe #1887

merged 1 commit into from
May 4, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1846

Test Plan

How do we know the code works?

Checklist

  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2021 •
edited
Loading

Timestamp: 2021-05-04 11:29:38
Buildscan url for ubuntu-workflow run 809865532
https://gradle.com/s/37flffjciirs6

@bootstraponline bootstraponline force-pushed the 1846_structural_output_android_describe branch 2 times, most recently from f242b59 to 3d220f3 Compare May 3, 2021 18:23
pawelpasterz
pawelpasterz approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@pawelpasterz pawelpasterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, LGTM!

@bootstraponline bootstraponline force-pushed the 1846_structural_output_android_describe branch from 3d220f3 to 1ef6154 Compare May 3, 2021 19:03
Sloox
Sloox suggested changes May 4, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small required change from @pawelpasterz

@piotradamczyk5 piotradamczyk5 requested a review from Sloox May 4, 2021 07:09
@piotradamczyk5
Copy link
Contributor Author

small required change from @pawelpasterz

@Sloox fixed

@piotradamczyk5 piotradamczyk5 force-pushed the 1846_structural_output_android_describe branch from 305ff04 to da223ce Compare May 4, 2021 11:19
@piotradamczyk5 piotradamczyk5 force-pushed the 1846_structural_output_android_describe branch from da223ce to 07c399e Compare May 4, 2021 11:24
@mergify mergify bot merged commit 26d516e into master May 4, 2021
@mergify mergify bot deleted the 1846_structural_output_android_describe branch May 4, 2021 13:24
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structural output - DescribeAndroidModels
3 participants
@piotradamczyk5 @Sloox @pawelpasterz