refactor: Describe ios locales #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sloox
requested review from
bootstraponline,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Sloox
commented
Apr 30, 2021
...ain/kotlin/ftl/presentation/cli/firebase/test/ios/configuration/IosLocalesDescribeCommand.kt
Outdated
Show resolved
Hide resolved
|
Timestamp: 2021-05-06 07:05:45 |
bootstraponline
force-pushed
the
#1849-describe-ios-locales
branch
from
9b09140 to
010e28d
Compare
pawelpasterz
approved these changes
May 3, 2021
bootstraponline
force-pushed
the
#1849-describe-ios-locales
branch
from
010e28d to
4f07d26
Compare
bootstraponline
force-pushed
the
#1849-describe-ios-locales
branch
from
4f07d26 to
1259007
Compare
bootstraponline
force-pushed
the
#1849-describe-ios-locales
branch
from
1259007 to
fb722ac
Compare
pawelpasterz
approved these changes
May 5, 2021
piotradamczyk5
approved these changes
May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1849
Test Plan
Code is refactored according to the description in #1849
Needs clarification that it follows 100% the correct methodology for passing of values.
Checklist