Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor DescribeNetworkProfiles logging #1885

Merged
merged 2 commits into from
Apr 30, 2021
Merged

refactor: Refactor DescribeNetworkProfiles logging #1885

merged 2 commits into from
Apr 30, 2021

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1853

Test Plan

How do we know the code works?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2021 •
edited
Loading

Timestamp: 2021-04-30 06:16:11
Buildscan url for ubuntu-workflow run 798510570
https://gradle.com/s/rqgenhywclpby

@pawelpasterz pawelpasterz marked this pull request as ready for review April 29, 2021 21:05
@bootstraponline bootstraponline force-pushed the 1853-structural-output-describe-network-profile branch from 9a098ae to 2342154 Compare April 29, 2021 22:53
@pawelpasterz pawelpasterz force-pushed the 1853-structural-output-describe-network-profile branch from 2342154 to af885e9 Compare April 30, 2021 06:11
@pawelpasterz pawelpasterz enabled auto-merge (squash) April 30, 2021 06:17
Sloox
Sloox approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@pawelpasterz pawelpasterz merged commit e7cd357 into master Apr 30, 2021
@pawelpasterz pawelpasterz deleted the 1853-structural-output-describe-network-profile branch April 30, 2021 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jan-goral jan-goral jan-goral approved these changes

@Sloox Sloox Sloox approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structural output - DescribeNetworkProfiles
3 participants
@pawelpasterz @Sloox @jan-goral