Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor data scratch-Junit test result #1884

Merged
merged 2 commits into from
May 6, 2021
Merged

refactor: Refactor data scratch-Junit test result #1884

merged 2 commits into from
May 6, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Apr 29, 2021 •
edited
Loading

Fixes #1757

Test Plan

How do we know the code works?

Checklist

  • Unit tested
  • Integration tests updated

@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/6c5e3aacp5obw
Linux status failure - Build scan: https://gradle.com/s/q2v7mcvitkqjc
Workflow run https://github.com/Flank/flank/actions/runs/796869560

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2021 •
edited
Loading

Timestamp: 2021-05-06 10:52:36
Buildscan url for ubuntu-workflow run 816560059
https://gradle.com/s/koph42rgsbgyy

@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review April 30, 2021 15:45
@pawelpasterz
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link

mergify bot commented May 3, 2021

Command rebase: failure

Pull request can't be updated with latest base branch changes
GitHub App like Mergify are not allowed to merge pull request where .github/workflows is changed.`nThis pull request must be merged manually.
err-code: 75A3F

@pawelpasterz pawelpasterz force-pushed the 1757_refactor_junit branch from eb81998 to dcb3287 Compare May 4, 2021 21:47
@pawelpasterz pawelpasterz enabled auto-merge (squash) May 4, 2021 21:47
@piotradamczyk5 piotradamczyk5 force-pushed the 1757_refactor_junit branch from d93cae5 to f04d7e6 Compare May 6, 2021 10:47
@pawelpasterz pawelpasterz merged commit 82a0817 into master May 6, 2021
@pawelpasterz pawelpasterz deleted the 1757_refactor_junit branch May 6, 2021 10:56
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@Sloox Sloox Awaiting requested review from Sloox

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data scratch - junit test result
3 participants
@piotradamczyk5 @pawelpasterz @adamfilipow92