feat: Corellium adapters #1880
feat: Corellium adapters #1880
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jan-goral
requested review from
Sloox,
adamfilipow92,
zuziaka,
pawelpasterz and
piotradamczyk5
|
Timestamp: 2021-05-03 07:42:49 |
|
Should be reviewed and merged after #1878 |
bootstraponline
force-pushed
the
1799_Corellium_client
branch
2 times, most recently
from
2869c94 to
9f7c894
Compare
jan-goral
force-pushed
the
1799_Corellium_adapter
branch
from
4e50f68 to
20c2300
Compare
|
@bootstraponline commit: 372ac24 The ADB log lines from the two consoles are mixed, this behavior will be fixed in further changes. In the next step probably I will integrate multimodule sharding. |
|
@jan-gogo sounds good! |
| import kotlinx.coroutines.launch | ||
|
|
||
| object ExecuteAndroidTestPlan : AndroidTestPlan.Execute { | ||
| override suspend fun AndroidTestPlan.Config.invoke(): Flow<String> = |
| private suspend fun startNotRunningInstances( | ||
| instances: List<Instance> | ||
| ): Unit = instances | ||
| .filter { it.state != "on" } |
There was a problem hiding this comment.
It might be worth making "on" a constant as its used in multiple places.
Up to you :)
There was a problem hiding this comment.
I see its been defined already, can it be used here?
corellium/adapter/src/test/kotlin/flank/corellium/adapter/Example.kt
Outdated
Show resolved
Hide resolved
bootstraponline
force-pushed
the
1799_Corellium_adapter
branch
3 times, most recently
from
dac305b to
e68c19a
Compare
Fix InstallAndroidApps Update Example.kt
…ple.kt Co-authored-by: Michael Wright <[email protected]>
bootstraponline
force-pushed
the
1799_Corellium_adapter
branch
from
e68c19a to
a8aeb32
Compare
Fixes #1837
Test Plan
The example code should execute tests on Corellium devices and stream output from
am instrumentcommandIs not needed to testing this PR carefully because the adapter implementation could change during further integration and the final MVP testing.