Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add storage dir support #1874

Merged
merged 4 commits into from
Apr 28, 2021
Merged

Conversation

wclausen
Copy link
Contributor

@wclausen wclausen commented Apr 26, 2021

Fixes #1873

Test Plan

Updated the tests in ValidateDirectoriesToPullAndroidArgsTest to include changes in this PR

Checklist

  • Documented
  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@wclausen wclausen force-pushed the add_storage_dir_support branch from e64c991 to e60ffcf Compare April 26, 2021 14:14
@github-actions github-actions bot added the Bug label Apr 26, 2021
@mergify
Copy link

mergify bot commented Apr 26, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@pawelpasterz
Copy link
Contributor

Thanks for PR!
LGTM, just sign CLA and we're good to go :)

@mergify
Copy link

mergify bot commented Apr 27, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@Sloox Sloox changed the title Add storage dir support bugfix: Add storage dir support Apr 27, 2021
@Sloox Sloox changed the title bugfix: Add storage dir support bug: Add storage dir support Apr 27, 2021
@Sloox Sloox changed the title bug: Add storage dir support fix: Add storage dir support Apr 27, 2021
@wclausen
Copy link
Contributor Author

@pawelpasterz great! I wrote this as part of my work at Dropbox and had to get the legal team to sign off on me signing the CLA. I don't anticipate an issue and will sign as soon as I get the go-ahead.

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Sloox
Copy link
Contributor

Sloox commented Apr 28, 2021

@wclausen if you run into any issue with the CLA and cannot sign for any reason. Let us know and we will implement the changes for you. You are welcome to ping anyone who has reviewed this and we will gladly do it for you. 😄

@wclausen
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mergify mergify bot merged commit b8dc2bc into Flank:master Apr 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flank fails on valid directories-to-pull inputs, /storage dirs not supported
5 participants