-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add storage dir support #1874
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
e64c991
to
e60ffcf
Compare
Title does not follow the guidelines of Conventional Commits.
|
Thanks for PR! |
Title does not follow the guidelines of Conventional Commits.
|
@pawelpasterz great! I wrote this as part of my work at Dropbox and had to get the legal team to sign off on me signing the CLA. I don't anticipate an issue and will sign as soon as I get the go-ahead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@wclausen if you run into any issue with the CLA and cannot sign for any reason. Let us know and we will implement the changes for you. You are welcome to ping anyone who has reviewed this and we will gladly do it for you. 😄 |
I have read the CLA Document and I hereby sign the CLA |
Fixes #1873
Test Plan
Updated the tests in
ValidateDirectoriesToPullAndroidArgsTest
to include changes in this PRChecklist