Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor data scratch-performance metrics #1840

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1752

Test Plan

How do we know the code works?

Checklist

  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2021

Timestamp: 2021-04-26 05:55:25
Buildscan url for ubuntu-workflow run 784454824
https://gradle.com/s/npnwzdkoxfwfw

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes :)

data class Duration(val seconds: Long)
data class Duration(
val seconds: Long,
val nanos: Int? = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If seconds is in Long, should not nanos be Long too? It potentially can be a larger number.

Copy link
Contributor Author

@piotradamczyk5 piotradamczyk5 Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is copy-pasted from google api 🙉

@bootstraponline bootstraponline force-pushed the 1752_performance_metrics_refactor branch from 7943a39 to baf2141 Compare April 26, 2021 05:50
@mergify mergify bot merged commit 53b3fd3 into master Apr 26, 2021
@mergify mergify bot deleted the 1752_performance_metrics_refactor branch April 26, 2021 06:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data scratch - performance metrics
3 participants