Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add sharding implementation for corellium #1835

Merged
merged 8 commits into from
Apr 27, 2021
Merged

feat: Add sharding implementation for corellium #1835

merged 8 commits into from
Apr 27, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Apr 22, 2021 •
edited
Loading

Fixes #1801

The implementation of multi-module sharding

README

Test Plan

How do we know the code works?

Unit test passes

Checklist

  • Documented
  • Unit tested
  • Update diagram URL in README file after approvals

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jan-goral jan-goral marked this pull request as ready for review April 22, 2021 16:43
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2021 •
edited
Loading

Timestamp: 2021-04-27 11:28:36
Buildscan url for ubuntu-workflow run 788891287
https://gradle.com/s/gct2c3zp6ip5a

@mergify
Copy link

mergify bot commented Apr 22, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@jan-goral jan-goral self-assigned this Apr 22, 2021
@mergify
Copy link

mergify bot commented Apr 22, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@jan-goral jan-goral changed the title Add sharding implementation for corellium feat: Add sharding implementation for corellium Apr 22, 2021
Sloox
Sloox suggested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes :)

corellium/shard/README.md Outdated Show resolved Hide resolved
corellium/shard/README.md Outdated Show resolved Hide resolved
corellium/shard/README.md Outdated Show resolved Hide resolved
corellium/shard/README.md Outdated Show resolved Hide resolved
corellium/shard/src/main/kotlin/flank/corellium/shard/Internal.kt Outdated Show resolved Hide resolved
corellium/shard/src/main/kotlin/flank/corellium/shard/Internal.kt Show resolved Hide resolved
corellium/shard/src/main/kotlin/flank/corellium/shard/Internal.kt Show resolved Hide resolved
@bootstraponline bootstraponline force-pushed the 1801_Multi-module_sharding_algorithm branch 5 times, most recently from 8f67863 to dfa72e5 Compare April 26, 2021 06:52
@bootstraponline bootstraponline force-pushed the 1801_Multi-module_sharding_algorithm branch from 3747ff0 to a7a5239 Compare April 26, 2021 15:19
jan-goral and others added 3 commits April 27, 2021 11:22
@bootstraponline bootstraponline force-pushed the 1801_Multi-module_sharding_algorithm branch from a7a5239 to 923a017 Compare April 27, 2021 11:23
@mergify mergify bot merged commit f54ecc1 into master Apr 27, 2021
@mergify mergify bot deleted the 1801_Multi-module_sharding_algorithm branch April 27, 2021 11:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zuziaka zuziaka zuziaka approved these changes

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

Assignees

@jan-goral jan-goral

Labels
Corellium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-module sharding algorithm
4 participants
@jan-goral @Sloox @zuziaka @piotradamczyk5