refactor: Refactor data scratch-device model #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
bootstraponline,
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
piotradamczyk5
force-pushed
the
1745_refactor_device_models
branch
from
344d0bb to
9bfcdcb
Compare
|
Timestamp: 2021-04-22 15:40:28 |
adamfilipow92
approved these changes
Apr 22, 2021
Sloox
approved these changes
Apr 23, 2021
| } | ||
|
|
||
| internal fun List<IosModel>.toIosApiModel(): List<DeviceModel.Ios> = map { googleiOSModel -> | ||
| DeviceModel.Ios( |
There was a problem hiding this comment.
The capitialization of iOS is always a strange one to me. should it be?
Suggested change
| DeviceModel.Ios( | |
| DeviceModel.IOS( |
or
Suggested change
| DeviceModel.Ios( | |
| DeviceModel.iOS( |
or just leave it is as it is ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1745
Test Plan
android models describeios models describeandroid models listios models describeChecklist