Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: data scratch getLocales #1828

Merged
merged 10 commits into from
Apr 27, 2021
Merged

refactor: data scratch getLocales #1828

merged 10 commits into from
Apr 27, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Apr 22, 2021 •
edited
Loading

Fixes #1747

Test Plan

Checklist

  • Unit tested

@Sloox Sloox self-assigned this Apr 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2021 •
edited
Loading

Timestamp: 2021-04-27 11:11:21
Buildscan url for ubuntu-workflow run 788848977
https://gradle.com/s/rlpp3ul5ajhji

@Sloox
Copy link
Contributor Author

Sloox commented Apr 24, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/pwcpox2patuog
Linux status failure - Build scan: https://gradle.com/s/3l5krgbarchna
Workflow run https://github.com/Flank/flank/actions/runs/780470561

@Sloox Sloox requested a review from piotradamczyk5 April 26, 2021 13:50
jan-goral
jan-goral suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jan-goral jan-goral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The domain layer cannot have direct references to the adapter or client implementation.

test_runner/src/main/kotlin/ftl/adapter/google/ListLocales.kt Outdated Show resolved Hide resolved
@Sloox Sloox requested a review from jan-goral April 27, 2021 11:06
@Sloox Sloox enabled auto-merge (squash) April 27, 2021 11:19
@Sloox Sloox disabled auto-merge April 27, 2021 11:21
@Sloox Sloox merged commit fbc8c47 into master Apr 27, 2021
@Sloox Sloox deleted the #1747-locales branch April 27, 2021 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@Sloox Sloox

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data scratch - locale
4 participants
@Sloox @pawelpasterz @jan-goral @piotradamczyk5