Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor data scratch-remote storage #1810

Merged
merged 21 commits into from
Apr 22, 2021
Merged

refactor: Refactor data scratch-remote storage #1810

merged 21 commits into from
Apr 22, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Apr 15, 2021 •
edited
Loading

Fixes #1753

Test Plan

How do we know the code works?

Checklist

  • Unit tested

@Sloox Sloox self-assigned this Apr 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2021 •
edited
Loading

Timestamp: 2021-04-22 14:20:47
Buildscan url for ubuntu-workflow run 774504480

@jan-goral jan-goral marked this pull request as draft April 15, 2021 08:26
@Sloox Sloox changed the title refactor: Refactor data scratchremote storage refactor: Refactor data scratch-remote storage Apr 15, 2021
@Sloox Sloox marked this pull request as ready for review April 16, 2021 07:05
jan-goral
jan-goral suggested changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@jan-goral jan-goral left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The adapters cannot be accessible directly from the domain code. In other words, the domain layer cannot be aware of adapters.
  • The data layer is a bridge between the domain layer and adapters.

Pls follow the rules presented in the following diagram:

architecture diagram

@Sloox Sloox requested a review from jan-goral April 16, 2021 12:38
@Sloox
Copy link
Contributor Author

Sloox commented Apr 16, 2021

@jan-gogo please confirm. More changes have been made.

@piotradamczyk5
Copy link
Contributor

@jan-gogo please confirm. More changes have been made.

@Sloox please check comment and apply changes according to it

@Sloox Sloox marked this pull request as draft April 19, 2021 10:01
@Sloox Sloox marked this pull request as ready for review April 20, 2021 08:19
@Sloox Sloox enabled auto-merge (squash) April 20, 2021 11:28
@Sloox Sloox requested a review from jan-goral April 21, 2021 12:04
@Sloox Sloox requested a review from piotradamczyk5 April 22, 2021 10:14
@Sloox
Copy link
Contributor Author

Sloox commented Apr 22, 2021

@piotradamczyk5 issues addressed. Please review.

@Sloox Sloox requested a review from piotradamczyk5 April 22, 2021 11:10
@Sloox Sloox merged commit 42b4be2 into master Apr 22, 2021
@Sloox Sloox deleted the #1753-remote-storage branch April 22, 2021 14:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jan-goral jan-goral jan-goral approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

Assignees

@Sloox Sloox

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data scratch - remote storage
3 participants
@Sloox @piotradamczyk5 @jan-goral