refactor: Refactor data scratch-authorization #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
bootstraponline,
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
piotradamczyk5
force-pushed
the
1740-refactor_data_scratch_authorization
branch
2 times, most recently
from
2da812b to
c101dc5
Compare
|
Timestamp: 2021-04-15 13:29:24 |
piotradamczyk5
force-pushed
the
1740-refactor_data_scratch_authorization
branch
from
c101dc5 to
922ad06
Compare
jan-goral
approved these changes
Apr 14, 2021
Sloox
approved these changes
Apr 15, 2021
| import ftl.data.UserAuthorization | ||
|
|
||
| object GoogleUserAuthorizationRequest : | ||
| UserAuthorization.Request, |
There was a problem hiding this comment.
hmmm ktlint formatting for this is stupid. I will look into it in some time.
bootstraponline
force-pushed
the
1740-refactor_data_scratch_authorization
branch
from
922ad06 to
fba8b4c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1740
Test Plan
flank auth loginruns without any problemsChecklist