-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix missing junit report in legacy mode #1807
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Timestamp: 2021-04-19 09:44:28 |
@flank-it |
Integration tests failed ❌ |
@flank-it |
Integration tests succeed for all OSes ✅ |
8382809
to
0b37496
Compare
0b37496
to
7b68e99
Compare
@flank-it |
Integration tests were triggered at 2021-04-19 10:41:22, you can track progress here |
Fixes #1778
Test Plan
All tests should pass, when using android tests with legacy mode Flank should generate JUnitReport in the results directory, performance metrics file should be created.
This pr is a revert of @piotradamczyk5 change related to
performanceMetrics.json
creation. I was checking this feature and still works fine.To test if
performanceMetrics.json
are created:performanceMetrics.json
to gcsCheck if local matrix directories contain
performanceMetrics.json
Run the same Flank configuration on the current master and compare
performanceMetrics.json
.Test results
performanceMetrics.json
from this branch linkperformanceMetrics.json
from current master linkChecklist