Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 1795 update custom sharding it #1796

Merged
merged 1 commit into from
Apr 12, 2021
Merged

test: 1795 update custom sharding it #1796

merged 1 commit into from
Apr 12, 2021

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1795

Test Plan

How do we know the code works?

  1. run ./gradlew flankFullRun
  2. run ./gradlew integrationTests --tests CustomShardingIT on windows ❗
  3. no errors 🎉

@pawelpasterz pawelpasterz self-assigned this Apr 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pawelpasterz pawelpasterz force-pushed the 1795-update-custom-sharding-it branch from cfbfd7f to a47afb0 Compare April 12, 2021 06:48
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2021 •
edited
Loading

Timestamp: 2021-04-12 07:21:39
Buildscan url for ubuntu-workflow run 740244252
https://gradle.com/s/xrkm6wbzp7xyu

Sloox
Sloox suggested changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A marker for my confirmation so its not automerged,.

@bootstraponline bootstraponline force-pushed the 1795-update-custom-sharding-it branch from a47afb0 to 37306d1 Compare April 12, 2021 07:17
@pawelpasterz pawelpasterz requested a review from Sloox April 12, 2021 07:40
@Sloox
Copy link
Contributor

Sloox commented Apr 12, 2021

@flank-it

@mergify mergify bot merged commit 1368150 into master Apr 12, 2021
@mergify mergify bot deleted the 1795-update-custom-sharding-it branch April 12, 2021 07:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@zuziaka zuziaka zuziaka approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

Assignees

@pawelpasterz pawelpasterz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update/fix CustomShardingIT on windows
3 participants
@pawelpasterz @Sloox @zuziaka