-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add 3dmark instrumented test #1783
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Seems it requires a fix of ui-automator script, locally it works fine, on the emulator with the same resolution. |
d773f49
to
90785ed
Compare
Timestamp: 2021-04-14 20:52:24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments.
import flank.scripts.utils.runCommand | ||
import java.nio.file.Paths | ||
|
||
// TODO Design common abstraction for building apks and coping artifacts, add java doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth making a ticket so its not forgotten about?
# For more details, see | ||
# http://developer.android.com/guide/developing/tools/proguard.html | ||
|
||
# If your project uses WebView with JS, uncomment the following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can technically remove this file.
Everyline is commented out :)
@jan-gogo is it worth to add the pictures to documentation as it will be lost in this PR? |
Fixes #1771
The instrumented test based on ui-automator should run a benchmark on the tested device.
The benchmark must be installed on the tested device.
Goal
Running the benchmark on FTL device and obtaining the benchmark results.
Config
https://github.com/Flank/flank/blob/1771_ftl_benchmarks/test_runner/src/test/kotlin/ftl/fixtures/benchmark.yml
Details
apk
file is specified usingadditional-apks
option/sdcard/Android/data/com.futuremark.dmandroid.application/files/3DMarkAndroid/
Test Plan
copy
Geekbench 5_v5.3.2.apk
3dmarkandroid-v2-1-4726.apk
to
test_artifacts/1771_ftl_benchmarks/apk/benchmark/
Devices
Results
3dmarkandroid-v2-1-4726.apk
Geekbench - all passed 836e622 firebase
PassMark
Checklist