Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix entrypoint file name #1782

Merged
merged 3 commits into from
Apr 7, 2021
Merged

fix: Fix entrypoint file name #1782

merged 3 commits into from
Apr 7, 2021

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1780

Test Plan

How do we know the code works?

  1. Run ./gradlew flankFullRun
  2. Unit tests pass
  3. Follow 'steps to reproduce' in ftl.Main changed to ftl.MainKt in 21.04.0 breaking scripts and Fladle. #1780
    1. Update flank in fladle to 21.04.0 with flankVersion = '21.04.0'
    2. ./gradlew runFlank
    3. task proceeds without error

Checklist

  • Unit tested

@pawelpasterz pawelpasterz self-assigned this Apr 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pawelpasterz pawelpasterz enabled auto-merge (squash) April 7, 2021 05:12
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2021 •
edited
Loading

Timestamp: 2021-04-07 07:58:17
Buildscan url for ubuntu-workflow run 725263673
https://gradle.com/s/qhu4jtg3arzl6

@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/oxflqffzklham
Linux status failure - Build scan: https://gradle.com/s/73vj7ewbp5yxs
Workflow run https://github.com/Flank/flank/actions/runs/724903293

@pawelpasterz
Copy link
Contributor Author

Integration tests were triggered at 2021-04-07 05:20:17, you can track progress here

Will probably fail on windows...

@pawelpasterz
Copy link
Contributor Author

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/oxflqffzklham
Linux status failure - Build scan: https://gradle.com/s/73vj7ewbp5yxs
Workflow run https://github.com/Flank/flank/actions/runs/724903293

Ah quota...

runningcode
runningcode reviewed Apr 7, 2021
View reviewed changes
test_runner/src/test/kotlin/ftl/MainTest.kt
"java",
"-cp",
System.getProperty("java.class.path"),
"ftl.Main"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test. Thanks.

@piotradamczyk5 piotradamczyk5 self-requested a review April 7, 2021 07:15
@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2021

Integration tests were triggered at 2021-04-07 07:20:34, you can track progress here

@bootstraponline bootstraponline force-pushed the 1780-fix-entrypoint-file-name branch from bd1f722 to d7c31de Compare April 7, 2021 07:52
@pawelpasterz pawelpasterz merged commit d2ce59b into master Apr 7, 2021
@pawelpasterz pawelpasterz deleted the 1780-fix-entrypoint-file-name branch April 7, 2021 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@runningcode runningcode runningcode approved these changes

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
Bug P0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ftl.Main changed to ftl.MainKt in 21.04.0 breaking scripts and Fladle.
4 participants
@pawelpasterz @runningcode @Sloox @piotradamczyk5