Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add printing total run duration #1773

Merged
merged 5 commits into from
Apr 8, 2021
Merged

feat: Add printing total run duration #1773

merged 5 commits into from
Apr 8, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Apr 1, 2021 •
edited
Loading

Fixes #1666

Test Plan

How do we know the code works?

Total run duration is printed after Flank run with detailed log level set.

  1. Set log level detailed
  2. Run Flank
  3. Check if you have time report at the end of run, ex:
Total run duration: 3m 11s
	- Preparation: 0m 6s
	- Running tests: 0m 6s
	- Executing matrices: 2m 50s
	- Generating reports: 0m 4s

Checklist

  • Documented
  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@piotradamczyk5 piotradamczyk5 force-pushed the #1666_add_printing_total_run_duration branch 5 times, most recently from f9979bc to c12b915 Compare April 2, 2021 14:27
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review April 2, 2021 14:27
@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status success - Build scan: https://gradle.com/s/kppw3s6cejpa4
Linux status success - Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/711912478

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021 •
edited
Loading

Timestamp: 2021-04-08 17:30:58
Buildscan url for ubuntu-workflow run 730381921
https://gradle.com/s/7bu5v4j5pxfqm

@piotradamczyk5
Copy link
Contributor Author

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status success - Build scan: https://gradle.com/s/kppw3s6cejpa4
Linux status success - Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/711912478

Windows failed as for others

@pawelpasterz
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status success - Build scan: https://gradle.com/s/jfdog3h675x2y
Linux status success - Build scan: https://gradle.com/s/y242hhfmpwszc
Workflow run https://github.com/Flank/flank/actions/runs/721493629

@bootstraponline bootstraponline force-pushed the #1666_add_printing_total_run_duration branch from c12b915 to 9e94019 Compare April 6, 2021 07:14
@piotradamczyk5
Copy link
Contributor Author

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status success - Build scan: https://gradle.com/s/jfdog3h675x2y
Linux status success - Build scan: https://gradle.com/s/y242hhfmpwszc
Workflow run https://github.com/Flank/flank/actions/runs/721493629

Windows failed as for others jobs

@piotradamczyk5
Copy link
Contributor Author

@asadsalman please check if it works as expected 😃

@bootstraponline bootstraponline force-pushed the #1666_add_printing_total_run_duration branch from 9e94019 to de6d1cb Compare April 6, 2021 11:24
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) April 6, 2021 17:28
@asadsalman
Copy link
Contributor

This looks really good, thank you!

@bootstraponline
Copy link
Contributor

  • Running tests: 0m 6s
  • Executing matrices: 2m 50s

what is the difference between running tests and executing matrices? Is test running a subset of the matrix execution?

Sloox
Sloox reviewed Apr 7, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

test_runner/src/main/kotlin/ftl/Main.kt Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/domain/RunTestAndroid.kt Outdated Show resolved Hide resolved
test_runner/src/test/kotlin/ftl/run/status/TestMatrixStatusPrinterTest.kt Show resolved Hide resolved
@piotradamczyk5
Copy link
Contributor Author

Running tests: 0m 6s
Executing matrices: 2m 50s
what is the difference between running tests and executing matrices? Is test running a subset of the matrix execution?

Running tests stage if for preparing matrix to run (creating context, matrices, uploading files)
Executing matrices is running them on the FTL side.
Test running is not a subset of matrix execution, naming for those stages are inspired by code methods

@piotradamczyk5 piotradamczyk5 force-pushed the #1666_add_printing_total_run_duration branch from de6d1cb to 2a59e6a Compare April 7, 2021 15:38
@piotradamczyk5 piotradamczyk5 requested a review from Sloox April 7, 2021 15:40
Sloox
Sloox approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bootstraponline bootstraponline force-pushed the #1666_add_printing_total_run_duration branch 2 times, most recently from 85bfde7 to 6a16a4f Compare April 8, 2021 14:12
@Sloox
Copy link
Contributor

Sloox commented Apr 8, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status success - Build scan:
Linux status success - Build scan: https://gradle.com/s/m2zetu3zbew4w
Workflow run https://github.com/Flank/flank/actions/runs/730183896

@bootstraponline bootstraponline force-pushed the #1666_add_printing_total_run_duration branch from 32b8f46 to aac4179 Compare April 8, 2021 17:25
@piotradamczyk5 piotradamczyk5 merged commit 3a21357 into master Apr 8, 2021
@piotradamczyk5 piotradamczyk5 deleted the #1666_add_printing_total_run_duration branch April 8, 2021 17:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@Sloox Sloox Sloox approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Feature P1 Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print run duration
5 participants
@piotradamczyk5 @pawelpasterz @asadsalman @bootstraponline @Sloox