-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1665 implement custom sharding -- android #1763
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Timestamp: 2021-04-06 07:21:05 |
442f599
to
e6e8ec0
Compare
test_runner/src/main/kotlin/ftl/run/platform/android/ResolveApks.kt
Outdated
Show resolved
Hide resolved
test_runner/src/main/kotlin/ftl/run/model/AndroidTestContext.kt
Outdated
Show resolved
Hide resolved
3e9220e
to
5a3e1be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments and fixes.
@flank-it |
Integration tests failed ❌ |
Quota limit exceeded... |
Great job!!! 🚀 Let's wait with approval until quota refresh and run IT tests once again tomorrow. |
e967854
to
f96f25b
Compare
d82ef10
to
7e83bd7
Compare
7e83bd7
to
43d1a4d
Compare
@flank-it |
Integration tests succeed for all OSes ✅ |
@jan-gogo IT pass, let me know if I should put some more effort into this PR or it's good to merge |
43d1a4d
to
1861f45
Compare
Android part for #1665
Detailed documentation
This is the first implementation of the custom sharding feature, below assumptions were made:
sharding-json
is the source of truth -- no smart sharding appliedTest Plan
./gradlew flankFullRun
flank firebase test android run -c=[YOUR CONFIG] --dump-shards
android_shards.json
, rename it and play around with shards, example: add another shard, move tests etcsharding-json: [PATH TO YOUR CUSTOM SHARDING JSON]
to your config yamlflank firebase test android run -c=[YOUR CONFIG] --dump-shards
android_shards.json
(notice that shards are properly assigned to app-test apk pairs)flank firebase test android run -c=[YOUR CONFIG]
Note:
Checklist