fix: Removed mandatory GitHub token on artifacts downloading #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jan-goral
reviewed
Mar 30, 2021
flank-scripts/src/main/kotlin/flank/scripts/ops/testartifacts/Helpers.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Góral <[email protected]>
…Helpers.kt Co-authored-by: Jan Góral <[email protected]>
|
Timestamp: 2021-03-30 17:04:35 |
flank-scripts/src/main/kotlin/flank/scripts/data/github/GithubApi.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+3
to
+4
| fun getEnv(key: String, default: String? = null): String = | ||
| System.getenv(key) ?: default ?: throw RuntimeException("Environment variable '$key' not found!") |
There was a problem hiding this comment.
nit: With this function changed we could also update
and make it a bit simpler
piotradamczyk5
approved these changes
Mar 31, 2021
Sloox
approved these changes
Mar 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1695
Test Plan
Flank should download test artifacts without any exceptions when GitHub token is not set in environment variables.