Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add IT for large shard test suite #1737

Merged
merged 1 commit into from
Mar 26, 2021
Merged

test: Add IT for large shard test suite #1737

merged 1 commit into from
Mar 26, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Mar 25, 2021 •
edited
Loading

Fixes #1650

Test Plan

How do we know the code works?

New IT succeed.

Checklist

  • Integration tests updated

@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

Timestamp: 2021-03-25 16:54:51
Buildscan url for ubuntu-workflow run 687256462
https://gradle.com/s/vb6oloq7jqipo

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/e7667dkfyecno
Linux status failure - Build scan: https://gradle.com/s/webnikda6mhwe
Workflow run https://github.com/Flank/flank/actions/runs/687256988

@piotradamczyk5 piotradamczyk5 self-assigned this Mar 25, 2021
@piotradamczyk5
Copy link
Contributor Author

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/e7667dkfyecno
Linux status failure - Build scan: https://gradle.com/s/webnikda6mhwe
Workflow run https://github.com/Flank/flank/actions/runs/687256988

quota limit...

adamfilipow92
adamfilipow92 approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code looks good
  • on local machine, test passed

@adamfilipow92
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

Integration tests were triggered at 2021-03-26 08:31:57, you can track progress here

@mergify mergify bot merged commit c144f80 into master Mar 26, 2021
@mergify mergify bot deleted the #1650_add_it_for_large_shards branch March 26, 2021 08:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@Sloox Sloox Sloox approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@jan-goral jan-goral Awaiting requested review from jan-goral

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Tech Debt Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IT for #1649
3 participants
@piotradamczyk5 @adamfilipow92 @Sloox