Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Improve integration tests #1719

Merged
merged 10 commits into from
Mar 23, 2021
Merged

test: Improve integration tests #1719

merged 10 commits into from
Mar 23, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Mar 22, 2021 •
edited
Loading

Fixes #1616

Test Plan

How do we know the code works?

All integration tests succeed

Checklist

  • Integration tests updated

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/jec3eitrbnsrc
Linux status failure - Build scan: https://gradle.com/s/vxcfujwrpwy7i
Workflow run https://github.com/Flank/flank/actions/runs/676083956

@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/h5pqkkzyskusu
Linux status failure - Build scan: https://gradle.com/s/6ice6kmpkytgg
Workflow run https://github.com/Flank/flank/actions/runs/676319099

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021 •
edited
Loading

Timestamp: 2021-03-23 15:30:09
Buildscan url for ubuntu-workflow run 680054678
https://gradle.com/s/y3pofgcx5wvwg

@piotradamczyk5 piotradamczyk5 force-pushed the 1616-integration-tests-by-json-output branch from ce252b7 to 3181a0d Compare March 22, 2021 14:42
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review March 22, 2021 15:32
@bootstraponline bootstraponline force-pushed the 1616-integration-tests-by-json-output branch from d94585e to 7e190e3 Compare March 23, 2021 08:32
@mergify
Copy link

mergify bot commented Mar 23, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@piotradamczyk5 piotradamczyk5 changed the title tests: Improve integration tests test: Improve integration tests Mar 23, 2021
@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/5no23jylunypm
Linux Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/679304409

@bootstraponline bootstraponline force-pushed the 1616-integration-tests-by-json-output branch from 7e190e3 to b87f2ec Compare March 23, 2021 12:13
@bootstraponline bootstraponline force-pushed the 1616-integration-tests-by-json-output branch from b87f2ec to e0bbb53 Compare March 23, 2021 15:24
@mergify mergify bot merged commit 756d76c into master Mar 23, 2021
@mergify mergify bot deleted the 1616-integration-tests-by-json-output branch March 23, 2021 19:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jan-goral jan-goral jan-goral approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@Sloox Sloox Awaiting requested review from Sloox

@zuziaka zuziaka Awaiting requested review from zuziaka

Assignees

@adamfilipow92 adamfilipow92

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve integration tests by json output
4 participants
@piotradamczyk5 @pawelpasterz @jan-goral @adamfilipow92