Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Extract logic from cli to domain #1718

Merged
merged 6 commits into from
Mar 25, 2021
Merged

refactor: Extract logic from cli to domain #1718

merged 6 commits into from
Mar 25, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Mar 22, 2021 •
edited
Loading

Fixes #1638

This is only refactoring, no changes in logic, just moving the implementation around functions and packages.

Test Plan

  • All tests should pass

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jan-goral jan-goral force-pushed the 1638-extract_commands_logic_from_cli branch from 60365cb to f586f9f Compare March 22, 2021 11:20
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021 •
edited
Loading

Timestamp: 2021-03-25 12:17:48
Buildscan url for ubuntu-workflow run 686448526
https://gradle.com/s/ooyrkiipvwliq

@jan-goral jan-goral marked this pull request as ready for review March 23, 2021 07:53
@jan-goral jan-goral removed the Feature label Mar 23, 2021
@mergify
Copy link

mergify bot commented Mar 24, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@adamfilipow92
Copy link
Contributor

Please add a prefix to title refactor

adamfilipow92
adamfilipow92 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code loogs good
  • All tests pass

@piotradamczyk5 piotradamczyk5 changed the title Extract logic from cli to domain refactor: Extract logic from cli to domain Mar 25, 2021
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) March 25, 2021 12:12
@piotradamczyk5 piotradamczyk5 merged commit b6f811e into master Mar 25, 2021
@piotradamczyk5 piotradamczyk5 deleted the 1638-extract_commands_logic_from_cli branch March 25, 2021 12:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

@Sloox Sloox Awaiting requested review from Sloox

@zuziaka zuziaka Awaiting requested review from zuziaka

Assignees

@jan-goral jan-goral

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract commands logic from CLI
4 participants
@jan-goral @adamfilipow92 @pawelpasterz @piotradamczyk5