Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Flutter support #1714

Merged
merged 19 commits into from
Mar 24, 2021
Merged

docs: Flutter support #1714

merged 19 commits into from
Mar 24, 2021

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Mar 18, 2021 •
edited by jan-goral
Loading

Fixes #1690

Test Plan

How do we know the code works?

Currently Flank cannot run Flutter tests.

Here is example of building and running Flutter on gcloud ./test_projects/flutter/flutter_example/build_and_run_tests_firebase

Documentation about status can be find in docs/flutter_status.md

Checklist

  • Documented

@adamfilipow92 adamfilipow92 self-assigned this Mar 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2021 •
edited
Loading

Timestamp: 2021-03-24 11:46:10
Buildscan url for ubuntu-workflow run 682901196
https://gradle.com/s/esug66thfz6m2

@adamfilipow92 adamfilipow92 marked this pull request as ready for review March 18, 2021 13:26
@mergify
Copy link

mergify bot commented Mar 18, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@adamfilipow92 adamfilipow92 changed the title doc: Flutter support docs: Flutter support Mar 18, 2021
jan-goral
jan-goral reviewed Mar 18, 2021
View reviewed changes
jan-goral
jan-goral reviewed Mar 18, 2021
View reviewed changes
docs/flutter_status.md Outdated
Comment on lines 83 to 84
receive information's in ```IntegrationTestPlugin``` in method ```onMethodCall```. ```FlutterTestRunner``` sets test
statuses in method ```run``` (lines: 78, 82, 84).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have hyperlinks for specified lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hyperlinks added!

jan-goral
jan-goral reviewed Mar 18, 2021
View reviewed changes
docs/flutter_status.md Outdated
1. Firebase can run flutter tests. You can find example in ```test_projects/flutter```,
simple run ```./build_and_run_tests_firebase```.

1. Firebase not supporting sharding for Flutter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be explained in more detail.
Add script with commands used for tests, also the output with error will be useful.
Or direct link to firebase documentation explaining that is not supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a command example and describe test lab behavior.

@piotradamczyk5 piotradamczyk5 self-requested a review March 22, 2021 12:25
jan-goral
jan-goral suggested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@jan-goral jan-goral left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing gcloud tests & results for the following commands:

@jan-goral jan-goral self-assigned this Mar 23, 2021
jan-goral
jan-goral reviewed Mar 23, 2021
View reviewed changes
@bootstraponline bootstraponline force-pushed the 1690-flutter-example branch 4 times, most recently from 2580d8f to cfdd574 Compare March 24, 2021 08:37
@jan-goral jan-goral self-requested a review March 24, 2021 11:37
adamfilipow92 and others added 17 commits March 24, 2021 11:40
@mergify mergify bot merged commit 8dafa00 into master Mar 24, 2021
@mergify mergify bot deleted the 1690-flutter-example branch March 24, 2021 11:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@jan-goral jan-goral jan-goral approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

Assignees

@jan-goral jan-goral

@adamfilipow92 adamfilipow92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare Flutter example for Flank
4 participants
@adamfilipow92 @pawelpasterz @jan-goral @piotradamczyk5