-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add app name to the test result #1704
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Timestamp: 2021-03-22 08:14:09 |
@flank-it |
Integration tests failed ❌ |
iosXcTest, | ||
iosTestLoop | ||
) | ||
.firstOrNull { it != null } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange formatting to have a random endline character?
Personal preference or auto corrected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatKotlin
did that, I'm not happy with it neither but who am I to challenge it :D
Being serious, I'll think of another formatting that is inline with kotlin format task
private val appIpa: FileReference? | ||
) { | ||
val gcsPath: String? | ||
get() = (appApk ?: testsZip ?: appIpa)?.gcsPath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting resolution, nice and neat but make sure we dont have any order of preference issues here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order doesn't matter in that case since only one will have a value that is non-null. It comes from TestSpecification
object, and that one is a composition of specs:
androidInstrumentationTest
androidTestLoop
androidRoboTest
iosXcTest
iosTestLoop
Since we are allowed to run only one type of test per matrix only one from above is not null. All android specs have appApk
, iOS xc -- testsZip
and iOS loop -- appIpa
. Let me know if that answers your question :)
a3b675d
to
9684103
Compare
@flank-it |
Integration tests succeed for all OSes ✅ |
9684103
to
003dc14
Compare
@Mergifyio rebase |
003dc14
to
00662c2
Compare
Command
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Results table:
┌─────────┬──────────────────────┬───────────────┬────────────────────────────┬────────────────────────────────┐
│ OUTCOME │ MATRIX ID │ APP NAME │ TEST AXIS VALUE │ TEST DETAILS │
├─────────┼──────────────────────┼───────────────┼────────────────────────────┼────────────────────────────────┤
│ success │ matrix-3qnwchlja84yr │ app-debug.apk │ NexusLowRes-28-en-portrait │ 1 test cases passed, 1 skipped │
└─────────┴──────────────────────┴───────────────┴────────────────────────────┴────────────────────────────────┘
Output report:
"test_results": {
"matrix-3qnwchlja84yr": {
"app": "app-debug.apk",
"test-axises": [
{
"device": "NexusLowRes-28-en-portrait",
"outcome": "success",
"details": "1 test cases passed, 1 skipped",
"testSuiteOverview": {
"total": 2,
"errors": 0,
"failures": 0,
"flakes": 0,
"skipped": 1,
"elapsedTime": 3.36,
"overheadTime": 0.0
}
}
]
}
},
Code review ✅
00662c2
to
10322c6
Compare
Fixes #1674
PR adds a new column (
APP NAME
) to the result table and updates theoutputReport.json
structure with an apk file name.Test Plan
output-report: json
APP NAME
outputReport.json
test_results
structure is similar toChecklist